search

go-shiori / go-epub

Go library for creating EPUB files
MIT License
44 stars 7 forks source link

Can't append subsection to a subsection #16

Closed ALIBRAGIMOV closed 10 months ago

ALIBRAGIMOV commented 11 months ago

Processing of chapters into subchapters does not work correctly in the AddSubSection function, I get an error like ParentDoesNotExistError, I cannot correctly process more complex nesting.

Monirzadeh commented 11 months ago

Could you please share a sample of the code that you are running and getting this error?

ALIBRAGIMOV commented 11 months ago

check and run code from this link - https://go.dev/play/p/1HJDpdJJyp-

Monirzadeh commented 10 months ago

Hi @ALIBRAGIMOV Thanks for your bug report, it is very helpful. You can now add subsections wherever you want, If there is any other problem, please give us feedback :+1:

fmartingr commented 10 months ago

Hey @Monirzadeh, remember to release a new version so people can use this on their project by using a version and not a commit sha.

Monirzadeh commented 10 months ago

Hey @Monirzadeh, remember to release a new version so people can use this on their project by using a version and not a commit sha.

i try to review some of unit test and some improvement (some bug happen when we use custom name or specific custom name) i try to release a new version as soon as possible :+1:

fmartingr commented 10 months ago

Hey @Monirzadeh, remember to release a new version so people can use this on their project by using a version and not a commit sha.

i try to review some of unit test and some improvement (some bug happen when we use custom name or specific custom name) i try to release a new version as soon as possible 👍

👍 No rush at all! Just in case you forgot :)

Monirzadeh commented 10 months ago

@fmartingr i create a milestone to not forgot that. v1.3.0 or v1.2.1?

fmartingr commented 10 months ago

@fmartingr i create a milestone to not forgot that. v1.3.0 or v1.2.1?

If this was a fix I'd go with a fix release (v1.2.1), if there were changes to public methods a minor (v1.3.0)

ALIBRAGIMOV commented 10 months ago

Hi 👋, thanks for your help with this problem 🙏.