go-shiori / obelisk

Go package and CLI tool for saving web page as single HTML file
MIT License
249 stars 18 forks source link

Support DialContext for request #1

Closed waybackarchiver closed 3 years ago

waybackarchiver commented 4 years ago

Thank you for the open-source obelisk.

When I imported obelisk to use it, I found it doesn't support DialContext, thus adding a new DialContext feature. The new DialContext supported is designed to be used as a proxy to preserve privacy and security when saving the webpage.

Why not use a system environment proxy or similar that uses IP and port, such as $HTTP_PROXY?

One reason is I don't need the entire system to use the proxy, and the other I prefer to be able to call my program via the third-party Go package, such as https://github.com/cretz/bine/.

Please accept the pull request if you believe it is appropriate, thank you.