go-shiori / obelisk

Go package and CLI tool for saving web page as single HTML file
MIT License
249 stars 18 forks source link

Changes from downstream #10

Closed waybackarchiver closed 2 years ago

waybackarchiver commented 2 years ago

Hello there.

Thank you to @RadhiFadlillah for taking the time to develop obelisk. Because of our scope of work, we are also maintaining obelisk and adding several of the new features.

The goal of this merge request is to tell everyone that we have an active downstream branch, so if you are interested, please feel free to contribute.

Thank you also to @hellodword for his contribution.

fmartingr commented 2 years ago

Hey @waybackarchiver, first of all, amazing work both of you :)

Now that I've stepped up as maintaner here, are you considering going back to the upstream project or are you planning to keep maintaining the fork for your uses anyway? I can't possibly maintain all go-shiori's repositories myself and keep a good pace, and you are already familiar enough with Obelisk.

Let me know what you think!

waybackarchiver commented 2 years ago

It’s cool to hear this.

If the upstream remains active, I will also merge changes back to it in the future.

fmartingr commented 2 years ago

It’s cool to hear this. If the upstream remains active, I will also merge changes back to it in the future.

Is your use case very specific? How do you feel about maintaining this repository?

waybackarchiver commented 2 years ago

Sorry for not responding sooner. I used obelisk in the wayback related projects, and there are some features, essentially minor changes, that I believe match the upstream features.

fmartingr commented 2 years ago

Sorry for not responding sooner. I used obelisk in the wayback related projects, and there are some features, essentially minor changes, that I believe match the upstream features.

I was asking because I could gave you (and @hellodword) permissions on this repository if you feel like maintaining it, since you are dogfooding it and making improvements. But I don't know if you folks want to maintain upstream or if your changes requires deviation from the original in any way. Let me know what you think.

waybackarchiver commented 2 years ago

Our changes should not deviate from the upstream, and it would be great if we could be granted permission to maintain the upstream.

waybackarchiver commented 2 years ago

Sorry for not responding sooner. I used obelisk in the wayback related projects, and there are some features, essentially minor changes, that I believe match the upstream features.

I was asking because I could gave you (and @hellodword) permissions on this repository if you feel like maintaining it, since you are dogfooding it and making improvements. But I don't know if you folks want to maintain upstream or if your changes requires deviation from the original in any way. Let me know what you think.

And, what's your thoughts? @hellodword

hellodword commented 2 years ago

@waybackarchiver @fmartingr Glad to hear that this repository becomes the upstream again. :clinking_glasses:

Thanks but for some privacy reasons, my github account could not be a member of any organization, sorry.

I will contribute to this repository by creating issue and pull-requests in the future. :smiley:

fmartingr commented 2 years ago

That's fair!

I've invited @waybackarchiver to the repo. Please confirm that everything is alright.

I hope this speeds up development for this project :)

If you require anything related to the org/repo and want to reach me privately, you can use the mail in my github profile. I'll try and reach back ASAP.

waybackarchiver commented 2 years ago

@fmartingr Thank you for the invitation! I'm thrilled to be a part of this project, and I'll do everything I can to help it make progress.

waybackarchiver commented 2 years ago

Now that it's all been done, let us merge it.