do we realy need unsafe in code?

go-shiori / obelisk

Go package and CLI tool for saving web page as single HTML file

MIT License

246 stars 17 forks source link

do we realy need unsafe in code? #107

Open Monirzadeh opened 5 months ago

Monirzadeh commented 5 months ago

We should try this properly though, unsafe is, well... unsafe. If we see any kind of problem with it we can just remove s2b and properly cast to []byte, but I wonder why they choose to use a memory efficient approach here.

_Originally posted by @fmartingr in https://github.com/go-shiori/obelisk/pull/96#discussion_r1474595005_

for record https://github.com/go-shiori/obelisk/pull/96#discussion_r1475003755

github-actions[bot] commented 4 weeks ago

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days