search

go-shiori / obelisk

Go package and CLI tool for saving web page as single HTML file
MIT License
249 stars 18 forks source link

Optional to skip downloading resource errors? #4

Closed waybackarchiver closed 3 years ago

waybackarchiver commented 3 years ago

Hi @RadhiFadlillah,

When I save a webpage using Obelisk will be interrupted if there are a few errors (e.g. some of the images are missing). I think it should continue to download the remaining resources in this case.

I've optimized it for this situation by providing the option skip-resource-url-error to skip the error when the download fails, and it will still be interrupted by default (the original solution).

If you think it is pursued, I will make a PR.

hi019 commented 3 years ago

Unfortunately I'm not sure if this package is still maintained, I see your pr from 4 months ago hasn't recieved any activity :(

RadhiFadlillah commented 3 years ago

Sorry for late response everyone.

When I save a webpage using Obelisk will be interrupted if there are a few errors (e.g. some of the images are missing). I think it should continue to download the remaining resources in this case.

Agreed, that sounds good. If you don't mind, please submit the PR (btw, thanks for all of your PRs).

Unfortunately I'm not sure if this package is still maintained, I see your pr from 4 months ago hasn't recieved any activity :(

I apologize for that, I'm a bit busy these days between my daily job, first born, and freelance job so I haven't contribute in GitHub as often as before. I still maintain Obelisk though, since I still use it almost daily (thanks to how crazy this year has been, there are so many precious events to archive).

While I can't promise it, I believe I'll be able to check and accept the PRs at the latest on this weekend.

waybackarchiver commented 3 years ago

I've created a PR #6, please review and merge.

hi019 commented 3 years ago

@RadhiFadlillah Thank you! Take your time, I'm sure you have more important things :)

RadhiFadlillah commented 3 years ago

I've merged the PR, so I'll close this issue.