Start page bug - Githubissues

go-shiori / shiori

Simple bookmark manager built with Go

MIT License

9.34k stars 555 forks source link

Start page bug #788

Open LLKoder opened 11 months ago

LLKoder commented 11 months ago

Data

Shiori version: lastest
Database Engine: sqlite
Operating system: linux
CLI/Web interface/Web Extension: Web interface

Describe the bug / actual behavior

When I first open browser with Shiori I see error:

Error - Session has expired, please login again.

...instead login page.

If I click 'OK' it relocate me to login page, but why do I get error when I first open browser without any cookies?

2023-11-27_15-35

Monirzadeh commented 11 months ago

it show error because it can't find cookies that needed. @fmartingr can we redirect without show error or automatically redirect after 3 second (or at least if user open root?) currently it is a little confusing.

LLKoder commented 11 months ago

it show error because it can't find cookies that needed.

Yep, I said about this. Why show this error if users open this page first times. I understand if it show me in second, .. etc, but first times. I have not been even login Shiori at all.

fmartingr commented 10 months ago

This happens because the error logic in the frontend is centralised in a single place, that means that for any error that the API returns we show the error dialog. I agree that the best UX here would be to redirect to login directly, and if the user tried to access a page directly show a "You are not logged in, please authenticate" message in the login page. After login in, the user will get redirected to the page that was trying to open.