search

go-shiori / shiori

Simple bookmark manager built with Go
MIT License
9.28k stars 551 forks source link

Image Caching Issue When Re-creating Bookmarks #833

Closed DesarrolloAntonio closed 8 months ago

DesarrolloAntonio commented 8 months ago

Description

I've encountered a problem regarding image caching within the Shiori bookmark management app. Whenever I create a bookmark, delete it, and then create another one, the image from the first bookmark persists and is incorrectly associated with the new bookmark.

Steps to Reproduce

  1. Create a bookmark with a specific image.
  2. Delete the bookmark created in step 1.
  3. Create a new bookmark.

Expected Behavior

The new bookmark should not retain or display the image from the previously deleted bookmark. Instead, it should either have no image or display a new image if one is specified during the creation of the new bookmark.

Actual Behavior

The image from the first bookmark is displayed for the new bookmark, indicating an issue with how images are cached and reused after a bookmark is deleted.

Monirzadeh commented 8 months ago

Hi. Version 1.5.5 on web app too right? As I remember we fix that in 1.6 but I can't find that where exactly. Can you please test that in version 1.6 and see if it happen there too or not

fmartingr commented 8 months ago

I think this was solved in https://github.com/go-shiori/shiori/pull/775