go-shiori / shiori

Simple bookmark manager built with Go
MIT License
9.28k stars 551 forks source link

Invalid Json in Api v1 #850

Closed DesarrolloAntonio closed 7 months ago

DesarrolloAntonio commented 7 months ago

Data

Describe the bug / actual behavior

I'm trying to update my app PageKeeper (https://github.com/DesarrolloAntonio/Shiori-Android-Client) to api version v1. The authentication works correctly, but the part of obtaining the bookmarks returns an invalid JSON.

These are the data returned by the log. <-- 401 Unauthorized http://192.168.1.12:8080/api/v1/bookmarks/ (72ms) Content-Type: application/json; charset=utf-8 X-Request-Id: d479e66f-dbc1-4a6d-ab7c-6dd61eca857d Date: Wed, 28 Feb 2024 11:10:00 GMT Content-Length: 1302 {"ok":false,"message":null}{"ok":true,"message":[{"id":1,"url":"https://www.actualidadiphone.com/ios-17-3-release-candidate-ya-disponible/","title":"iOS 17.3 Release Candidate ya disponible","excerpt":"Apple ya tiene listas las próximas actualizaciones hoy ha lanzado las versiones Release Candidate de todos sus sistemas.","author":"Luis Padilla","public":1,"modified":"2024-01-18 08:49:19","imageURL":"","hasContent":true,"tags":[],"hasArchive":false,"hasEbook":false,"create_archive":false,"create_ebook":false},{"id":2,"url":"https://www.pinterest.es/pin/622059767304289211/","title":"Malèna iOS App UI Kit | App ui design, App interface design, Mobile application design","excerpt":"Nov 25, 2022 - Malèna is an elegant, modern and minimal shopping \u0026 retail app UI kit designed specially to fit right into the new iOS, iPhone and all other mobile devices. Malèna comes with more a set of more than 22 beautifully designed screens in total, highly customizable, well layered, vector and organized files. Malèna UI Kit is compatible with Sketch, Photoshop, XD \u0026 Figma Designed with care by Royalz Store","author":"","public":1,"modified":"2024-01-18 08:52:26","imageURL":"","hasContent":false,"tags":[],"hasArchive":false,"hasEbook":false,"create_archive":false,"create_ebook":false}]}

Monirzadeh commented 7 months ago

can you please place the request too?

DesarrolloAntonio commented 7 months ago

can you please place the request too?

This is the url I've used: http://192.168.1.12:8080/api/v1/bookmarks/ With the "X-Session-Id in the headers

I have only added /v1/ to the URL compared to version 1.5.

Monirzadeh commented 7 months ago

can you please place the request too?

This is the url I've used: http://192.168.1.12:8080/api/v1/bookmarks/ With the "X-Session-Id in the headers

I have only added /v1/ to the URL compared to version 1.5.

not all API migrate to v1 yet (update bookmark migrate). we have that in roadmap can you confirm old path work as expected to get bookmark. things that weird to me that you get 401

DesarrolloAntonio commented 7 months ago

can you please place the request too?

This is the url I've used: http://192.168.1.12:8080/api/v1/bookmarks/ With the "X-Session-Id in the headers I have only added /v1/ to the URL compared to version 1.5.

not all API migrate to v1 yet (update bookmark migrate). we have that in roadmap can you confirm old path work as expected to get bookmark. things that weird to me that you get 401

Yes, legacy API is working, I'll use only auth v1 endpoints at this moment with versión 1.6.

Monirzadeh commented 7 months ago

can you please place the request too?

This is the url I've used: http://192.168.1.12:8080/api/v1/bookmarks/ With the "X-Session-Id in the headers I have only added /v1/ to the URL compared to version 1.5.

not all API migrate to v1 yet (update bookmark migrate). we have that in roadmap can you confirm old path work as expected to get bookmark. things that weird to me that you get 401

Yes, legacy API is working, I'll use only auth v1 endpoints at this moment with versión 1.6.

update archive and ebook migrate to v1 too. complete list in http://127.0.0.1:8080/swagger/