go-shiori / shiori

Simple bookmark manager built with Go
MIT License
9.04k stars 546 forks source link

feat: allow direct pdf archives #942

Open fmartingr opened 3 weeks ago

fmartingr commented 3 weeks ago

This pull request aims to provide PDF archives for bookmarks by directly downloading the file.

Notable changes

Pending

Closes #929

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 36.41026% with 124 lines in your changes missing coverage. Please review.

Project coverage is 35.20%. Comparing base (4a5564d) to head (9d34bad).

:exclamation: Current head 9d34bad differs from pull request most recent head 8c1ed87

Please upload reports for the commit 8c1ed87 to get more accurate results.

Files Patch % Lines
internal/http/routes/bookmark.go 11.11% 32 Missing :warning:
internal/webserver/handler-api-ext.go 0.00% 24 Missing :warning:
internal/domains/archiver.go 0.00% 15 Missing :warning:
internal/domains/storage.go 0.00% 13 Missing :warning:
internal/webserver/handler-api.go 0.00% 10 Missing :warning:
internal/cmd/add.go 0.00% 9 Missing :warning:
internal/database/mysql.go 71.42% 4 Missing and 4 partials :warning:
internal/archiver/pdf.go 41.66% 7 Missing :warning:
internal/http/routes/api/v1/bookmarks.go 0.00% 4 Missing :warning:
internal/archiver/warc.go 87.50% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #942 +/- ## ========================================== + Coverage 35.17% 35.20% +0.02% ========================================== Files 61 63 +2 Lines 4065 4116 +51 ========================================== + Hits 1430 1449 +19 - Misses 2413 2443 +30 - Partials 222 224 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.