Open fmartingr opened 3 weeks ago
Attention: Patch coverage is 36.41026%
with 124 lines
in your changes missing coverage. Please review.
Project coverage is 35.20%. Comparing base (
4a5564d
) to head (9d34bad
).:exclamation: Current head 9d34bad differs from pull request most recent head 8c1ed87
Please upload reports for the commit 8c1ed87 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request aims to provide PDF archives for bookmarks by directly downloading the file.
Notable changes
ArchiverDomain
ArchiverDomain
initializes a list of archivers that try to match the content type, if it does, that archiver is used. If an error is raised, the next archiver is used and so on.PDFArchiver
: Just downloads the file.WARCArchiver
as a "catch all" (current default)bookmark.archiver
(warc
/pdf
) andarchive_path
.archive_path != ""
Pending
archive_path
for existing bookmarks: iterate over the bookmarks, check if the archive exists and set the path and thearchiver
towarc
.Closes #929