search

go-shiori / shiori

Simple bookmark manager built with Go
MIT License
9.04k stars 546 forks source link

fix: better style for quotes #951

Open Monirzadeh opened 2 weeks ago

Monirzadeh commented 2 weeks ago

This PR add better style for quotes in readable version. close #950

@romu70 @fmartingr any suggestion for better style? specifically in this design use Red is not too much eye caching for a quote. we can change design completely different.

Preview qoute

romu70 commented 2 weeks ago

My take

Screenshot 2024-07-03 at 13 54 22

romu70 commented 2 weeks ago

Fixed.

We can also think about having a soft color background instead of the gray, or having a color accent.

fmartingr commented 2 weeks ago

I would use something simple, a box with a bit darker/lighter background depending on the theme, the text in italics and probably nothing else, to match the simplicity of the rest of the themes.

Once we start working on custom css users could customize this to their needs.

Monirzadeh commented 2 weeks ago

@fmartingr any other change?

dark light

fmartingr commented 2 weeks ago

@fmartingr any other change?

Honestly I would be much more simple than that, I don't like extra distractions on transformations on the readable version.

Screenshot 2024-07-04 at 08 24 51

blockquote {
    padding: 15px;
    margin: 15px;
    font-style: italic;
    background: var(--bgqoute);
}

Also I would put this style under the #content section, so it only applies to the readable version.

Monirzadeh commented 2 weeks ago

done it is better to separate other page like content page CSS to a separate file too like archive.less