go-siris / siris

DEPRECATED: The community driven fork of Iris. The fastest web framework for Golang!
Other
142 stars 16 forks source link

[WIP] Feature/sessions with gc #45

Closed Dexus closed 7 years ago

Dexus commented 7 years ago
codecov[bot] commented 7 years ago

Codecov Report

Merging #45 into devel will decrease coverage by 4.19%. The diff coverage is 36.41%.

Impacted file tree graph

@@            Coverage Diff            @@
##            devel      #45     +/-   ##
=========================================
- Coverage   47.35%   43.16%   -4.2%     
=========================================
  Files          22       27      +5     
  Lines         963     1550    +587     
=========================================
+ Hits          456      669    +213     
- Misses        475      812    +337     
- Partials       32       69     +37
Impacted Files Coverage Δ
sessions/sess_file.go 1.29% <1.29%> (ø)
sessions/sess_mem.go 31.68% <31.68%> (ø)
sessions/session.go 41.78% <42.36%> (ø)
sessions/sess_utils.go 61.2% <61.2%> (ø)
sessions/sess_cookie.go 68.11% <68.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87aec87...336df45. Read the comment docs.

codecov[bot] commented 7 years ago

Codecov Report

Merging #45 into devel will increase coverage by 6.81%. The diff coverage is 74.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel      #45      +/-   ##
==========================================
+ Coverage   55.68%   62.49%   +6.81%     
==========================================
  Files          18       23       +5     
  Lines        1232     1925     +693     
==========================================
+ Hits          686     1203     +517     
- Misses        507      632     +125     
- Partials       39       90      +51
Impacted Files Coverage Δ
sessions/sess_utils.go 63.94% <63.94%> (ø)
sessions/sess_file.go 68.68% <68.68%> (ø)
sessions/session.go 72.77% <73.75%> (ø)
sessions/sess_cookie.go 89.61% <89.61%> (ø)
sessions/sess_mem.go 91.58% <91.58%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 97a1366...02e5209. Read the comment docs.

theodesp commented 7 years ago

Hey I just found that article comparing Badger Vs BoldDB https://medium.com/@hendra_zhong/badger-vs-boltdb-persistent-key-value-store-written-in-go-e94ada87048f

Maybe we can add a plugin for interfacing Badger as a session store

Dexus commented 7 years ago

@theodesp Hey I just found that article comparing Badger Vs BoldDB https://medium.com/@hendra_zhong/badger-vs-boltdb-persistent-key-value-store-written-in-go-e94ada87048f

Maybe we can add a plugin for interfacing Badger as a session store

I will create a new PR for that backend.