Closed Dexus closed 7 years ago
Merging #45 into devel will decrease coverage by
4.19%
. The diff coverage is36.41%
.
@@ Coverage Diff @@
## devel #45 +/- ##
=========================================
- Coverage 47.35% 43.16% -4.2%
=========================================
Files 22 27 +5
Lines 963 1550 +587
=========================================
+ Hits 456 669 +213
- Misses 475 812 +337
- Partials 32 69 +37
Impacted Files | Coverage Δ | |
---|---|---|
sessions/sess_file.go | 1.29% <1.29%> (ø) |
|
sessions/sess_mem.go | 31.68% <31.68%> (ø) |
|
sessions/session.go | 41.78% <42.36%> (ø) |
|
sessions/sess_utils.go | 61.2% <61.2%> (ø) |
|
sessions/sess_cookie.go | 68.11% <68.11%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 87aec87...336df45. Read the comment docs.
Merging #45 into devel will increase coverage by
6.81%
. The diff coverage is74.88%
.
@@ Coverage Diff @@
## devel #45 +/- ##
==========================================
+ Coverage 55.68% 62.49% +6.81%
==========================================
Files 18 23 +5
Lines 1232 1925 +693
==========================================
+ Hits 686 1203 +517
- Misses 507 632 +125
- Partials 39 90 +51
Impacted Files | Coverage Δ | |
---|---|---|
sessions/sess_utils.go | 63.94% <63.94%> (ø) |
|
sessions/sess_file.go | 68.68% <68.68%> (ø) |
|
sessions/session.go | 72.77% <73.75%> (ø) |
|
sessions/sess_cookie.go | 89.61% <89.61%> (ø) |
|
sessions/sess_mem.go | 91.58% <91.58%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 97a1366...02e5209. Read the comment docs.
Hey I just found that article comparing Badger Vs BoldDB https://medium.com/@hendra_zhong/badger-vs-boltdb-persistent-key-value-store-written-in-go-e94ada87048f
Maybe we can add a plugin for interfacing Badger as a session store
@theodesp Hey I just found that article comparing Badger Vs BoldDB https://medium.com/@hendra_zhong/badger-vs-boltdb-persistent-key-value-store-written-in-go-e94ada87048f
Maybe we can add a plugin for interfacing Badger as a session store
I will create a new PR for that backend.
Please check if the PR fulfills these requirements
The commit message follows our guidelines. See Contributing guide
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix and feature
What is the current behavior? (You can also link to an open issue here)
31
What is the new behavior (if this is a feature change)? Sessions with a correct Grabage Collector (GC) to free memory of old sessions.
Does this PR introduce a breaking change? Yes, the SessionManager is now a other.
Other information: Includes also a vendor update close #31