Allendar commented 7 years ago

Please check if the PR fulfills these requirements
The commit message follows our guidelines. See Contributing guide
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)? Middleware now has to be loaded externally. People who don't use it, won't get it from the base Siris repo anymore. This design is meant for future middleware addition to not bloat the main Siris repository and offer modular code building.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:

This change is

CLAassistant commented 7 years ago

All committers have signed the CLA.

Dexus commented 7 years ago

FYI Please rebase the branch.

Review status: 0 of 332 files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.

siris.go, line 32 at r1 (raw file):

  // middleware used in Default method
  requestLogger "github.com/go-siris/middleware-logger"
  "github.com/go-siris/middleware-recover"

Here you need to name it recover

_examples/beginner/basicauth/main.go, line 6 at r1 (raw file):

  "time"

  "github.com/go-siris/middleware-basicauth"

this need to named basicauth

_examples/beginner/pprof/main.go, line 7 at r1 (raw file):

  "github.com/go-siris/siris/context"

  "github.com/go-siris/middleware-pprof"

this need to be named pprof

_examples/beginner/recover/main.go, line 7 at r1 (raw file):

  "github.com/go-siris/siris/context"

  "github.com/go-siris/middleware-recover"

need to be named recover

_examples/beginner/request-logger/main.go, line 4 at r1 (raw file):


import (
  "github.com/go-siris/middleware-logger"

need to be named logger

_examples/intermediate/httptest/main.go, line 4 at r1 (raw file):


import (
  "github.com/go-siris/middleware-basicauth"

need to be named basicauth

_examples/intermediate/i18n/main.go, line 4 at r1 (raw file):


import (
  "github.com/go-siris/middleware-i18n"

need to be named i18n

coverage-tests/siris_test.go, line 17 at r1 (raw file):

  "gopkg.in/gavv/httpexpect.v1"

  "github.com/go-siris/middleware-basicauth"

need to be named basicauth

Comments from Reviewable

codecov-io commented 7 years ago

Codecov Report

Merging #61 into devel will decrease coverage by 0.1%. The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel      #61      +/-   ##
==========================================
- Coverage   63.34%   63.23%   -0.11%     
==========================================
  Files          23       21       -2     
  Lines        2008     1945      -63     
==========================================
- Hits         1272     1230      -42     
+ Misses        644      626      -18     
+ Partials       92       89       -3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 33bc89e...6fa6af5. Read the comment docs.

codecov-io commented 7 years ago

Codecov Report

Merging #61 into devel will decrease coverage by 0.1%. The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel      #61      +/-   ##
==========================================
- Coverage   63.34%   63.23%   -0.11%     
==========================================
  Files          23       21       -2     
  Lines        2008     1945      -63     
==========================================
- Hits         1272     1230      -42     
+ Misses        644      626      -18     
+ Partials       92       89       -3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 33bc89e...6fa6af5. Read the comment docs.

Dexus commented 7 years ago

Reviewed 52 of 339 files at r1, 7 of 7 files at r3, 1 of 261 files at r4. Review status: all files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.

Comments from Reviewable

Dexus commented 7 years ago

Review status: all files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.

siris.go, line 32 at r1 (raw file):

Previously, Dexus (Josef Fröhle) wrote…