go-skynet / helm-charts

go-skynet helm chart repository
55 stars 40 forks source link

fix: update pvc values usage in PersistentVolumeClaim #19

Closed zhekazuev closed 1 year ago

zhekazuev commented 1 year ago

Issue

Incorrect paths to models.persistence.pvc values in the PersistentVolumeClaim template cause PersistentVolumeClaim to generate an error and fail to start the pod.

Ref: https://github.com/go-skynet/helm-charts/issues/16

Changes:

How to check

# should not generate pvc template and not add the name of PVC in Deployment
helm template test charts/local-ai/ --set models.persistence.pvc.enabled=false

# should generate pvc template and add the name of PVC in Deployment
helm template test charts/local-ai/ --set models.persistence.pvc.enabled=true