coveralls
commented
3 years ago Pull Request Test Coverage Report for Build 517
- 28 of 46 (60.87%) changed or added relevant lines in 6 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.2%) to 56.235%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| encoding/gpkg/gpkg.go | 0 | 1 | 0.0% | ||
| geom.go | 0 | 1 | 0.0% | ||
| planar/triangulate/delaunay/subdivision/geom.go | 0 | 1 | 0.0% | ||
| encoding/gpkg/binary_header.go | 0 | 2 | 0.0% | ||
| cmp/compare.go | 0 | 4 | 0.0% | ||
| cmp/empty.go | 28 | 37 | 75.68% | ||
| <!-- | Total: | 28 | 46 | 60.87% | --> |
| Totals | |
|---|---|
| Change from base Build 515: | 0.2% |
| Covered Lines: | 6688 |
| Relevant Lines: | 11893 |
gdey
It was reported that one of our comparison functions was using math.NaN incorrectly. Turns out this comparison function was a duplicate of another function that was doing the comparison correctly, and had tests. Removed the duplicate function, and references to it were ported to the correct function.
fixes #115