Closed ear7h closed 5 years ago
Also, please rebase to the lastest version of master
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
encoding/mvt/tile.go | 0 | 32 | 0.0% | ||
encoding/mvt/prepare.go | 16 | 75 | 21.33% | ||
encoding/mvt/layer.go | 55 | 118 | 46.61% | ||
encoding/mvt/feature.go | 156 | 392 | 39.8% | ||
<!-- | Total: | 227 | 617 | 36.79% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
planar/triangulate/constraineddelaunay/triangulator.go | 9 | 57.78% | ||
<!-- | Total: | 9 | --> |
Totals | |
---|---|
Change from base Build 219: | -1.9% |
Covered Lines: | 5258 |
Relevant Lines: | 8728 |
var
block caused an issue with typing... I'm not sure if my approach is correct check 2e1bb2c@ear7h the only addition I would suggest is a quick README.md to the mvt package demonstrating how to use it.
This is two commits, the first is just a plain cut-over and the the second is some minor changes to the the
ScaleGeo
function.Also, the
mvt
package depends ongithub.com/golang/protobuf/proto
and based on previous discussions I did not vendor it since this is a library. Is this correct?