go-spatial / geom

Geometry interfaces to help drive interoperability within the Go geospatial community
MIT License
168 stars 37 forks source link

[encoding] revisions to WKT encode #83

Closed ear7h closed 4 years ago

ear7h commented 5 years ago

This would close #81, refer to that issue for more context.

There isn't much of a performance difference, most of the cpu time is spent in encodeFloat so slight logic changes don't mean much.

todo: add tests to the cmp functions

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 384


Changes Missing Coverage Covered Lines Changed/Added Lines %
encoding/wkt/wkt.go 0 1 0.0%
cmp/empty.go 80 102 78.43%
encoding/wkt/wkt_decode.go 34 63 53.97%
encoding/wkt/wkt_encode.go 169 230 73.48%
<!-- Total: 283 396 71.46% -->
Files with Coverage Reduction New Missed Lines %
planar/triangulate/constraineddelaunay/triangulator.go 3 58.52%
encoding/wkt/wkt_encode.go 10 65.9%
encoding/wkt/wkt.go 11 23.08%
<!-- Total: 24 -->
Totals Coverage Status
Change from base Build 377: -0.2%
Covered Lines: 30696
Relevant Lines: 51157

💛 - Coveralls