go-spatial / tegola-osm

Various scripts for importing and running a mirror of OSM with tegola
https://demo.tegola.io
MIT License
73 stars 26 forks source link

Missing Nepal #32

Closed PetersonGIS closed 6 years ago

PetersonGIS commented 6 years ago

Oddly we seem to be missing Nepal from ne_50m_admin_0_boundary_lines_land. It is not missing from our ne_10m nor our ne_110m downloads. The original file from Natural Earth does have it, as verified in qgis.

nepal

PetersonGIS commented 6 years ago

Here is what the corresponding Natural Earth shapefile looks like in QGIS, with Nepal highlighted: nepal2

Without highlight: nepal3

PetersonGIS commented 6 years ago

This seems like it is fixed in v0.6.1 (tested locally). Can we try clearing the cache in demo.tegola.io for zooms 3 and 4 to see if that fixes this there?

erictheise commented 6 years ago

I'm doing some work on the server right now and this fits right in.

erictheise commented 6 years ago

@PetersonGIS, I've installed v0.6.1 for the osm/demo project and regenerated the zoom level 3 & 4 tiles but don't see any difference. The data you're looking at is pulled from the server or a local copy?

PetersonGIS commented 6 years ago

Interesting. I was pulling from a local copy, which was originally from that data though. I'll dig deeper to further look at the data differences as well as the toml and json differences that there might be between my local setup and what's on the demo.

erictheise commented 6 years ago

My suspicion would be that there's a difference in the .toml. Nepal is in _disputed?

PetersonGIS commented 6 years ago

I was wrong, it isn't fixed locally. I was looking at ne.ne_50m_admin_0_countries rather than ne_50m_admin_0_boundary_lines_land. Nepal is still missing in ne_50m_admin_0_boundary_lines_land when served by tegola but not missing if we look at ne_50m_admin_0_boundary_lines_land in qgis.

PetersonGIS commented 6 years ago

Verified there are 361 rows in ne_50m_admin_0_boundary_lines_land as reported in both qgis and local natural earth db. Suspect 361 in our ne cloud db too. So something is making it not render though it is there in the db? It is a fully enclosed line, does that make a difference to the renderer?

PetersonGIS commented 6 years ago

Missing these fully enclosed lines in the ne_50m_admin_0_boundary_lines_land data too.

enclosedlines2

ARolek commented 6 years ago

@PetersonGIS turn simplification off for that layer locally. I have a feeling that polygon is getting removed during simplification. Simplification might not be necessary for those layers too since they're already simplified.

PetersonGIS commented 6 years ago

@ARolek that was the solution!

[[maps.layers]] name = "boundary_lines_land" provider_layer = "ne.ne_50m_admin_0_boundary_lines_land" dont_simplify = true min_zoom = 3 max_zoom = 4

ARolek commented 6 years ago

@PetersonGIS beautiful! PR has been merged. Time to close this one out ;-)