search

go-spatial / tegola-osm

Various scripts for importing and running a mirror of OSM with tegola
https://demo.tegola.io
MIT License
73 stars 26 forks source link

Rewrite setup instuctions in Readme for clarity #60

Closed adamakhtar closed 3 years ago

adamakhtar commented 4 years ago

This PR makes the setup instructions a little more explicit to help avoid any confusion (especially for OSM / Tegola beginners ).

Impetus for this PR comes from the discussion on this issue https://github.com/go-spatial/tegola-osm/issues/59#issuecomment-650293089

This originally started out as a personal blog post but I decided to just rewrite it and submit it as a PR. If its a little too verbose I have no problem with it being rejected or modified to suit the project's needs.

ARolek commented 3 years ago

@adamakhtar thanks for keeping this PR going, and apologies for the slow action on my end. I'm starting to make some updates to the documentation for tegola and I will get this in the queue. Your efforts are very much appreciated!

adamakhtar commented 3 years ago

@ARolek ahh I just realised my last commit shouldn't have been on this branch. Let me remove that and repush. I'll do that today or in the next few days.

adamakhtar commented 3 years ago

@ARolek related to my last comment, can I remove the last commit and force push the branch back up? Doesn't make sense for it to be part of this projects commit history.

ARolek commented 3 years ago

@adamakhtar a force push should be fine.

adamakhtar commented 3 years ago

@ARolek I have force pushed and the unwanted commit is no longer present. Sorry for the bother.

ARolek commented 3 years ago

Thank you for the contribution! Sorry I was so slow to go through this, but your enhancements are very much appreciated.

adamakhtar commented 3 years ago

Awesome, thanks @ARolek !