[dataprovider] Added Observability to postgis data provider

go-spatial / tegola

Tegola is a Mapbox Vector Tile server written in Go

http://tegola.io/

MIT License

1.28k stars 194 forks source link

[dataprovider] Added Observability to postgis data provider #780

Closed gdey closed 3 years ago

gdey commented 3 years ago

Observability of the postgis pool
MVTProvider has query time observability on a per map and zoom level
Provider has query time observability on a per map, per layer and zoom level

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 9b2c7660d-PR-780

32 of 180 (17.78%) changed or added relevant lines in 6 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.4%) to 44.995%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
provider/postgis/util.go	1	2	50.0%
atlas/layer.go	0	6	0.0%
atlas/atlas.go	0	8	0.0%
atlas/map.go	0	17	0.0%
provider/postgis/postgis.go	29	145	20.0%
<!--	Total:	32	180	17.78%	-->

Files with Coverage Reduction	New Missed Lines	%
provider/postgis/postgis.go	1	55.37%
<!--	Total:	1		-->

Totals
Change from base Build 236f86409:	-0.4%
Covered Lines:	5430
Relevant Lines:	12068

💛 - Coveralls

gdey commented 3 years ago

fixes #758

ear7h commented 3 years ago

One thing I noticed, that I don't think is from this PR is a missing nil check here: https://github.com/go-spatial/tegola/blob/5bfe906a356a1d0bd63230862f4bfcfa49103a6d/observability/prometheus/prometheus.go#L211 Because of the following line: https://github.com/go-spatial/tegola/blob/5bfe906a356a1d0bd63230862f4bfcfa49103a6d/observability/prometheus/prometheus.go#L154

gdey commented 3 years ago

One thing I noticed, that I don't think is from this PR is a missing nil check here:

https://github.com/go-spatial/tegola/blob/5bfe906a356a1d0bd63230862f4bfcfa49103a6d/observability/prometheus/prometheus.go#L211

Because of the following line:

https://github.com/go-spatial/tegola/blob/5bfe906a356a1d0bd63230862f4bfcfa49103a6d/observability/prometheus/prometheus.go#L154

fixed.

ARolek commented 3 years ago

@gdey I'm working on the local tests for this and realized the readme has not been updated with the new metrics. Please add those when you have a chance.