Utilize builtin go "embed" package to embed all static files needed by internal viewer UI

go-spatial / tegola

Tegola is a Mapbox Vector Tile server written in Go

http://tegola.io/

MIT License

1.26k stars 193 forks source link

Utilize builtin go "embed" package to embed all static files needed by internal viewer UI #785

Closed mapl closed 3 years ago

mapl commented 3 years ago

dist folder not included in source

ARolek commented 3 years ago

I'm a big fan of this PR, but we're in a peculiar situation where we need to keep supporting the old way of embedding assets. In an ideal situation, we could use go build flags to sniff the version of Go that's being used for building and use the embed package when the version is 1.16 or greater.

cc @gdey

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 6dfae95f3-PR-785

5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.05%) to 45.0%

Totals
Change from base Build 126d51113:	-0.05%
Covered Lines:	5427
Relevant Lines:	12060

💛 - Coveralls

ARolek commented 3 years ago

@mapl can you squash these commits when you have a chance? this is just about ready to be merged.

mapl commented 3 years ago

I made some git mistakes and decided to open another PR for this.