go-spatial / tegola

Tegola is a Mapbox Vector Tile server written in Go
http://tegola.io/
MIT License
1.26k stars 193 forks source link

ui: don't run bindata when using embed #801

Closed ear7h closed 2 years ago

ear7h commented 2 years ago

Since this required multiple files and there was another go file in the directory I moved it to its own directory.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1aafe76c1-PR-801


Files with Coverage Reduction New Missed Lines %
cache/redis/redis.go 6 93.41%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 8e12766c4: 0.1%
Covered Lines: 5460
Relevant Lines: 12093

💛 - Coveralls
gdey commented 2 years ago

@ear7h I'll take a look at this on Friday after #795

ARolek commented 2 years ago

This has been merged into master.

ARolek commented 2 years ago

@ear7h for some reason it appears this did not get properly merged. I'm re-opening and will figure out what's going on.

ARolek commented 2 years ago

I ended up dropping go-bindata entirely in this PR: https://github.com/go-spatial/tegola/pull/843. Closing in favor of that PR.