Issue 813 - auto identify build tags and make them available for runtime

go-spatial / tegola

Tegola is a Mapbox Vector Tile server written in Go

http://tegola.io/

MIT License

1.26k stars 193 forks source link

Issue 813 - auto identify build tags and make them available for runtime #823

Closed gdey closed 2 years ago

gdey commented 2 years ago

Automate the build of the build.Tags field.

Fixes #813

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build db6e825b5-PR-823

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 45.202%

Totals
Change from base Build e1b7fd1c2:	0.0%
Covered Lines:	5483
Relevant Lines:	12130

💛 - Coveralls

ARolek commented 2 years ago

This PR looks good overall (a few minor nits in my review). I think it's lacking a reference in a README / HACKING guide though.

gdey commented 2 years ago

This PR looks good overall (a few minor nits in my review). I think it's lacking a reference in a README / HACKING guide though.

I added a line to run (go generate ./...) to the Contribruating doc, but there isn't much else that needs to be done. That the main point of this is to simplify the developer experience.