ci: publish edge image on push or pr to default_branch_ref

go-spatial / tegola

Tegola is a Mapbox Vector Tile server written in Go

http://tegola.io/

MIT License

1.26k stars 193 forks source link

ci: publish edge image on push or pr to default_branch_ref #824

Closed iwpnd closed 2 years ago

iwpnd commented 2 years ago

Whenever something is pushed to Tegola default branch, publish an 0day/edge image.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build e6fe0cfe6-PR-824

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 45.202%

Totals
Change from base Build ec0faf28c:	0.0%
Covered Lines:	5483
Relevant Lines:	12130

💛 - Coveralls

gdey commented 2 years ago

This looks fine to me, but what is the reasoning behind it? Just so that we have a build that is on the latest version branch?

Nifty way of getting the current default branch!

iwpnd commented 2 years ago

I’d say it’s Part convenience for the user to get 0day images if they want to use and are comfy with it, and part for you maintainers to get feedback early. And to be ultimately honest, that way I don’t have to fork the current default in my own image, when I for example want to use Redis SSL or the newest pgx. 😅 Edge always indicating that it is potentially not stable.

gdey commented 2 years ago

FYI @ARolek is traveling right now, so I assume he will get to this sometime next week.