chore: remove logAndError

go-spatial / tegola

Tegola is a Mapbox Vector Tile server written in Go

http://tegola.io/

MIT License

1.28k stars 196 forks source link

chore: remove logAndError #839

Closed iwpnd closed 2 years ago

iwpnd commented 2 years ago

As discussed I'm removing the logAndError helper and let control logging for those three occasions in the error block. If you disagree with me on the Debug instead of the Info log, please feel free to just change it around. :)

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 59148f0ae-PR-839

6 of 10 (60.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 45.114%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
server/handle_map_layer_zxy.go	6	10	60.0%
<!--	Total:	6	10	60.0%	-->

Files with Coverage Reduction	New Missed Lines	%
server/handle_map_layer_zxy.go	1	77.5%
<!--	Total:	1		-->

Totals
Change from base Build 2fad34008:	-0.02%
Covered Lines:	5485
Relevant Lines:	12158

💛 - Coveralls

ARolek commented 2 years ago

@gdey do you think Debug or Info should be used in these log statements. That's the only real question in this PR.

gdey commented 2 years ago

@gdey do you think Debug or Info should be used in these log statements. That's the only real question in this PR.

I think debug is fine. I don't think these are really Info-level messages, as it might be expected to have these happen, but if you are trying to figure out why it's not happening then opening it up to debug would be good. The only other level I can think of that might make sense is TRACE, but that's supposed to be even more verbose than debug. So, debug is good.