Closed iwpnd closed 2 years ago
Totals | |
---|---|
Change from base Build 21da05b0a: | 0.0% |
Covered Lines: | 5485 |
Relevant Lines: | 12158 |
I have 2 minor requests:
That you for this addition!
@ARolek thank you for the review
add a docker-compose.env file with the various env vars that you have in the run command.
You'd have to check-in an docker-compose.env.example
file and tell the user to rename it.
This would also only allow me to do something like this in the docker-compose.yml
:
healthcheck:
test: ["CMD-SHELL", "pg_isready -U ${PGUSER} -d ${PGDATABASE}"]
It would not load the .env
environment variables into our local environment so go test
can use them. For this to work I'd have to refactor the test with a function to load the docker-compose.env
or something. So the command to run the local test would still need whatever environment variables tegola uses in tests.
Add the docker-compose commands to the readme
Once the above is solved :)
This PR adds a local development environment using docker compose as proposed here that makes local development a breeze, even if you're unfamiliar with the project.
docker compose up
docker compose down