Closed iwpnd closed 2 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
internal/log/log.go | 5 | 10 | 50.0% | ||
cmd/tegola/cmd/root.go | 2 | 18 | 11.11% | ||
internal/log/zap.go | 0 | 45 | 0.0% | ||
<!-- | Total: | 7 | 73 | 9.59% | --> |
Totals | |
---|---|
Change from base Build 7ac37b942: | -0.2% |
Covered Lines: | 5583 |
Relevant Lines: | 12319 |
The main thing I want to think through here is, do we really want to support 2 types of loggers?
While zap is fast, text logs have the edge in terms of performance because json serialization has an overhead. Giving the user the option is only fair as not every users wants to reap the benefits of json logs, or doesn't even care at all.
But ultimately that's your decision to make of course. :)
Do you want to move forward with this or drop @ARolek @gdey ?
@iwpnd we should move forward with it! I know others have asked about this as well. Let me bump @gdey so he can provide some input as well.
Hi 👋
As discussed in #831 I added the option to use structured logs with uber/zap while falling back to the currently implemented default if
--logger
is not specifically used. Log levels conform to the current implementation with the exception of log levelTRACE
that is not supported byzap
. I useDebug
as a fall back here.Looking forward for your feedback