go-spatial / tegola

Tegola is a Mapbox Vector Tile server written in Go
http://tegola.io/
MIT License
1.28k stars 195 forks source link

Build for embedded UI is failing #914

Closed gdey closed 1 year ago

gdey commented 1 year ago

We are getting an error in the CI when building the UI:

Run pushd ${GITHUB_WORKSPACE}/server
~/work/tegola/tegola/server ~/work/tegola/tegola
Changed to directory: /home/runner/work/tegola/tegola/ui
Running: npm version
Running: npm install
Running: npm run build
> 
> > tegola@0.1.0 build
> > vue-cli-service build
exit status 2
viewer_gen.go:1: running "go": exit status 1
> 
> Browserslist: caniuse-lite is outdated. Please run:
> npx browserslist@latest --update-db
> 
> Why you should do it regularly:
> https://github.com/browserslist/browserslist#browsers-data-updating
> 
> -  Building for production...
>  ERROR  Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './2020/CreateDataProperty' is not defined by "exports" in /home/runner/work/tegola/tegola/ui/node_modules/es-abstract/package.json
> Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './2020/CreateDataProperty' is not defined by "exports" in /home/runner/work/tegola/tegola/ui/node_modules/es-abstract/package.json
>     at new NodeError (node:internal/errors:399:5)
>     at exportsNotFound (node:internal/modules/esm/resolve:361:10)
>     at packageExportsResolve (node:internal/modules/esm/resolve:697:9)
>     at resolveExports (node:internal/modules/cjs/loader:565:36)
>     at Module._findPath (node:internal/modules/cjs/loader:634:31)
>     at Module._resolveFilename (node:internal/modules/cjs/loader:1061:27)
>     at Module._load (node:internal/modules/cjs/loader:920:27)
>     at Module.require (node:internal/modules/cjs/loader:1141:19)
>     at require (node:internal/modules/cjs/helpers:110:18)
>     at Object.<anonymous> (/home/runner/work/tegola/tegola/ui/node_modules/object.getownpropertydescriptors/implementation.js:3:26)
>     at Module._compile (node:internal/modules/cjs/loader:1254:14)
>     at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)
>     at Module.load (node:internal/modules/cjs/loader:1117:32)
>     at Module._load (node:internal/modules/cjs/loader:958:12)
>     at Module.require (node:internal/modules/cjs/loader:1141:19)
>     at require (node:internal/modules/cjs/helpers:110:18)
> 
PATH: /home/runner/go/bin:/opt/hostedtoolcache/go/1.18.10/x64/bin:/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
While running `npm run build`
Got error:
exit status 1
Error: Process completed with exit code 1.

see: https://github.com/go-spatial/tegola/actions/runs/4423598112/jobs/7797285048?pr=893

iwpnd commented 1 year ago

The viewer is ridden with vulnerabilities. Devils advocate here, does the viewer need to be embedded in the first place or can we take it out into its own repository to maintain it separately?

iwpnd commented 1 year ago

can you folks please take a look at #916 @ARolek @gdey?

ARolek commented 1 year ago

The viewer is ridden with vulnerabilities. Devils advocate here, does the viewer need to be embedded in the first place or can we take it out into its own repository to maintain it separately?

The embedded viewer has always been a really helpful part of standing up tegola. It can be removed with a build flag if desired. I would prefer we just address the outstanding vulns.