coveralls
commented
1 year ago Pull Request Test Coverage Report for Build 11c27a7f6-PR-915
- 13 of 42 (30.95%) changed or added relevant lines in 3 files are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage decreased (-0.01%) to 46.894%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| server/server.go | 1 | 2 | 50.0% | ||
| provider/hana/hana.go | 8 | 20 | 40.0% | ||
| provider/postgis/postgis.go | 4 | 20 | 20.0% | ||
| <!-- | Total: | 13 | 42 | 30.95% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| provider/hana/hana.go | 1 | 55.78% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build f56b286f1: | -0.01% |
| Covered Lines: | 6553 |
| Relevant Lines: | 13974 |
iwpnd
ARolek
gdey
mrylov
we encountered an issue where tegola would panic if you'd try to register duplicate metrics collectors. that would happen if you have more than one mvt provider in the same config file.
this fix makes provider metrics unique by adding the respective provider name to an array of constant labels. Upon collecting metrics on start up we'd pass unique metrics to the registration step and avoid said panic.
resolves: #886