search

go-spatial / tegola

Tegola is a Mapbox Vector Tile server written in Go
http://tegola.io/
MIT License
1.28k stars 195 forks source link

ci: rotate connection string #919

Closed iwpnd closed 1 year ago

gdey commented 1 year ago

@iwpnd did you see this comment? https://github.com/go-spatial/tegola/pull/893#discussion_r1136602372

I don't think, did you add the secret to this repo already?

iwpnd commented 1 year ago

@ARolek just did 🙂

iwpnd commented 1 year ago

Read the comment now. But I didn't before I reached out to @ARolek. Id say just put it in a secret not to keep SAP secure, but to not make tegola look bad.

ARolek commented 1 year ago

Maybe this PR should just add comments above that connection string and reference the original post?

iwpnd commented 1 year ago

your pick

ARolek commented 1 year ago

Let's go with code commenting per the submitters request.