search

go-spatial / tegola

Tegola is a Mapbox Vector Tile server written in Go
http://tegola.io/
MIT License
1.28k stars 195 forks source link

fix: cache/gcs dropped errs #938

Closed alrs closed 1 year ago

alrs commented 1 year ago

This picks up two dropped err variables in cache/gcs.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 2917c6ff8-PR-938

Totals Coverage Status
Change from base Build a7bf00420: 0.0%
Covered Lines: 6556
Relevant Lines: 13977
💛 - Coveralls
alrs commented 1 year ago

Done. I was following the example on https://github.com/go-spatial/tegola/blob/330368d51388203009e071bd1db256b0077c649d/cache/gcs/gcs.go#L64

Should I change that one as well?

ARolek commented 1 year ago

Should I change that one as well?

Ooof. Yes please!

alrs commented 1 year ago

I've replaced the log.Fatal() with a return, as well.