go-spatial / tegola

Tegola is a Mapbox Vector Tile server written in Go

http://tegola.io/

MIT License

1.28k stars 195 forks source link

[FIX] Issue 904 - Vue app doesn't take into account uri_prefix #967

Closed Nactik closed 7 months ago

Nactik commented 7 months ago

Fix #904 - uri_prefix not taken into account for the UI

Hey there, here's a quick PR to fix the way tegola UI is served when sitting behind a reverse proxy. I still need to implement and fix test but the idea is here (I will implement them asap)

Changes:

Added a new setting proxy_protocol (I can change it if you think of a better name) in the config file (config.toml) to set a custom protocol that will be used to generate the URLs included in the capabilities endpoint responses. (Useful when working under a reverse proxy and when the X-Forwarded-Proto is not a solution - Fix #134 )
When serving embedded files under a reverse proxy, strip the uri_prefix from the request (server/viewer_embed.go)
Adjust vite settings to include static file using a relative path

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build c9799a7f2-PR-967

Details

-3 of 10 (70.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.006%) to 46.861%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
cmd/tegola/cmd/server.go	0	3	0.0%
<!--	Total:	7	10	70.0%	-->

Totals
Change from base Build b7ad33baf:	0.006%
Covered Lines:	6575
Relevant Lines:	14031

💛 - Coveralls

ARolek commented 7 months ago

@Nactik nice! LMK when this is out of draft and I will give it a review.

Nactik commented 7 months ago

@ARolek It should be good now :)

ARolek commented 7 months ago

Just merged this into master. Great for contribution! Thank you.