search

go-spatial / tegola

Tegola is a Mapbox Vector Tile server written in Go
http://tegola.io/
MIT License
1.28k stars 195 forks source link

Layer names that are substrings cause atlas to serve all layers that match #995

Closed KoduIsGreat closed 3 months ago

KoduIsGreat commented 3 months ago

refers to #869

use direct comparison instead of strings.Contains to filter layernames

happy to discuss if we need to support both approaches.

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build be6ef56dc-PR-995

Details

Totals Coverage Status
Change from base Build 86cf1919d-PR-992: 0.0%
Covered Lines: 6551
Relevant Lines: 14024
💛 - Coveralls
gdey commented 3 months ago

@ARolek seems our dockerhub login key has expired.

iwpnd commented 3 months ago

Nah, this is because the PR does not have access to the credentials I believe. If you were to merge this now, it will have them @gdey. Maybe we can split the docker build step and make the publish step including login only happen on push to master.

ARolek commented 3 months ago

seems our dockerhub login key has expired.

This has to do with external PRs not being able to access the repo secrets. I have been trying to figure out how we could make that job conditional based on if you have access to the secrets or not. Here's a related discussion. Seems like a few work arounds also reference this iss.

ARolek commented 3 months ago

@KoduIsGreat can you please squash all the commits into a single one? I can help with this if you would like me to do it.

KoduIsGreat commented 3 months ago

I can do it this afternoon if you haven't got to it already

KoduIsGreat commented 3 months ago

@ARolek commits squashed

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 7613ca265-PR-995

Details

Totals Coverage Status
Change from base Build 86cf1919d-PR-992: 0.0%
Covered Lines: 6551
Relevant Lines: 14024
💛 - Coveralls