Open Monstrofil opened 4 days ago
Can you share the file please?
Sure. demo.zip
ps. change the table name to functional_zones_table.
I can confirm the issue in v0.20.0 and everything working in v0.19.0. Also took a look at the data and couldn't find anything wrong with it either. I was able to verify that the gpkg provider correctly gets the feature from the gpkg and creates a valid polygon. I'm not sure why, but the issues appears to occur during encoding to mvt.
I have a feeling this has to do with this PR https://github.com/go-spatial/tegola/pull/952.
@gdey can you give us some guidance on what our best path forward here is? It seems to me that upgrading the geom package has caused a regression in rendering. I think the geom package version was bumped to bring in a fix for the slippy package to get tests to pass on Apple Silicon. This was discussed in https://github.com/go-spatial/tegola/issues/951
I need to look into this, and the other one listed here. I'll take a look tomorrow. See what I can find, but it does look like an issue with geom.
Just for a sanity check. The mvt_postgis provider is not affected.
Just for a sanity check. The mvt_postgis provider is not affected.
Correct. The mvt_postgis
provider does all geoprocessing in PostGIS. The Geopackage provider does the geoprocessing in tegola, which is why this is showing up only in the geopackage provider.
which is why this is showing up only in the geopackage provider.
just tested the legacy postgis
provider. Same issue there for geometry_type=polygon
but fine for geometry_type=linestring
. 👀
@iwpnd indeed, the same issue would show up for the legacy postgis provider. The geom package's line handling is fine, but the polygon handling is where the issues stem from.
Yeah, this looks like an old regression I had with makevalid. Where it would drop certain points due to floating point precision errors.
I have this minimal config:
When running with gospatial/tegola:v0.20.0, I get this:![image](https://github.com/go-spatial/tegola/assets/174041930/a813e235-0f44-4804-b66f-ae2883ce7362)
When i switch to gospatial/tegola:v0.19.0, geometry becomes normal:![image](https://github.com/go-spatial/tegola/assets/174041930/87a6d2c1-41fb-4719-9a14-e9871213332a)
I believe there is a bug in v20.