search

go-sprout / sprout

From sprig to sprout - Useful template functions for Go templates with steroids
https://sprout.atom.codes
MIT License
86 stars 4 forks source link

bug: missing TxtFuncMap #29

Closed andig closed 4 months ago

andig commented 4 months ago

Describe the bug

Boticed when upgrading from 0.2. While not strictly necessary, this is a nice helper and required to maintain compatibility.

To Reproduce

see below

Expected behavior

Function available

Code Snippet

template.New("yaml").Funcs(sprout.TxtFuncMap()).Parse(...)

Version of software

v0.3.0

Additional context

No response

Code of Conduct

andig commented 4 months ago

Note: if this is accepted as issue I'd consider it a regression in 0.3

42atomys commented 4 months ago

What a chaotic migration 🤦 Apologies for missing this functions, missing functions are :

This is a regression and I takes the decision to rollback the v0.3.0 to include back the functions !

42atomys commented 4 months ago

@andig you can re-pull v0.3.0 version the issue has addressed directly on the version to prevent regression

Thanks again for your reactivity 🙏

andig commented 4 months ago

you can re-pull v0.3.0 version the issue has addressed directly on the version to prevent regression

Btw, that is a particularly bad idea. One the version has been cached- either goproxy or in e.g. Github actions cache- it will not be pulled again. The proper way to fix this is a new release and- if very bad- retracting the old release. Not a big thing, but this shouldn't become a habit. In this case, it has made 0.3.0 unusable for me.