Closed 42atomys closed 2 months ago
First self feedback: allow registry to register aliases with functions
Second step :
Currently start the last step :
🎉 This pull request are done in case of functionalities and tests. This will be merged soon as the documentation are ready too
Hi @ccoVeille, thanks for your contribution in reviewing this big PR 💜
According to multiple comments on the crypto package, this package was backported from sprig and will be dropped in a few versions due to significant security issues.
I've been focusing on rewriting and enhancing other registries, so I haven't made any changes to this one.
Old code is not funny. Noted
it looks really good! I liked the registry idea, and the implementation looks good!
lgtm!
Thanks @ccoVeille and @caarlos0 for your time and your contribution to reviewing this next step of Sprout 🌱 💜
Attention: Patch coverage is 96.87500%
with 39 lines
in your changes missing coverage. Please review.
Files | Coverage Δ | |
---|---|---|
alias.go | 100.0% <100.0%> (ø) |
|
error.go | 100.0% <100.0%> (ø) |
|
handler.go | 100.0% <100.0%> (ø) |
|
internal/helpers/helpers.go | 100.0% <100.0%> (ø) |
|
pesticide/rand_test_helpers.go | 100.0% <100.0%> (ø) |
|
pesticide/test_helpers.go | 100.0% <100.0%> (ø) |
|
registry.go | 100.0% <100.0%> (ø) |
|
registry/checksum/functions.go | 100.0% <100.0%> (ø) |
|
registry/conversion/functions.go | 100.0% <100.0%> (ø) |
|
registry/encoding/functions.go | 95.8% <100.0%> (ø) |
|
... and 39 more |
Description
Following the discussion about function loading in #31, this huge refactor implement each method behind multiples registries.
TODO
Changes
FuncsMap
register all registry by defaultFixes #10
Checklist
Additional Information
This update following the discussions #31