search

go-sql-driver / mysql

Go MySQL Driver is a MySQL driver for Go's (golang) database/sql package
https://pkg.go.dev/github.com/go-sql-driver/mysql
Mozilla Public License 2.0
14.52k stars 2.32k forks source link

Cut a new v1.7.2 release #1534

Closed derekperkins closed 8 months ago

derekperkins commented 10 months ago

There are still several issues in the v1.8 milestone, so that may still be a ways out. Could we get a v1.7.2 release containing fixes from the last 9 months?

arnehormann commented 9 months ago

@methane / @shogo82148 I don't know the current state of the project, but the request sounds reasonable. And the milestone planning looks quite stale. Do you see any blockers concerning a release?

methane commented 9 months ago

Current master branch contains number of new features and changes. If there are important fix, I will create 1.7 branch and cherrypick them. But "9 months" is unclear to me. What bugfix is important for you?

I want to merge compression before 1.8. But it is possible to postpone some changes to 1.9 and release 1.8 before Go 1.22.

derekperkins commented 9 months ago

I'm personally interested in this fix https://github.com/go-sql-driver/mysql/pull/1432, which will hopefully then get picked up by grafana.

As of now, there are 48 commits since 1.7.1 last April. I wasn't sure what triggered a new release, since there hasn't been a consistent cadence. https://github.com/go-sql-driver/mysql/compare/v1.7.1...master

methane commented 9 months ago

1432 looks not a bugfix, but a new feature with small backward incompatibility.

So focusing 1.8 would be better.

owbone commented 9 months ago

https://github.com/go-sql-driver/mysql/pull/1473 is an important bug fix for us that we'd be grateful to have in a v1.7.2 release.

ravarage commented 8 months ago

and also drop support for 5.7 as its reached end of life

derekperkins commented 8 months ago

@methane Is this the PR you're hoping to land before v1.8?

methane commented 8 months ago

@derekperkins Yes, I was. But now I think it is better to make 1.8 before merging it because it is large PR. We can merge it right after we released 1.8. Users can try compression by using @master.

ldanielw1 commented 8 months ago

Gotcha - do you know what the timeline might be for a 1.8 release? Eagerly awaiting it as well, esp. with the ed25519 support

methane commented 8 months ago

No plan. I want to make it as fast as possible. But our review process make us slow.

sujit-baniya commented 8 months ago

and also drop support for 5.7 as its reached end of life

@ravarage like in horror story there might be some applications that still might be using mysql 5.7

methane commented 8 months ago

I don't plan to drop MySQL 5.7 support this time. Maybe, 1.9 may drop it. But "drop support" doesn't mean "don't work". It just mean we won't maintain CI for MySQL 5.7.

methane commented 8 months ago

https://github.com/go-sql-driver/mysql/releases/tag/v1.8.0

derekperkins commented 8 months ago

Thanks @methane!