search

go-sqlite / sqlite3

pure-Go sqlite3 file reader
BSD 3-Clause "New" or "Revised" License
140 stars 19 forks source link

Abstract database interface slightly #26

Closed AndreRenaud closed 6 years ago

AndreRenaud commented 6 years ago

At the moment we require the sqlite3 database to be in an on-disk file. We can abstract this slightly to allow an interface-based database to be opened

sbinet commented 6 years ago

also, could you send another PR where you'd add yourself to the AUTHORS and CONTRIBUTORS files ? (thanks)

sbinet commented 6 years ago

@AndreRenaud do you need some help with the PR squashing?

AndreRenaud commented 6 years ago

PR squashing is ok (I think), what I missed was available time :)

I've skipped the AUTHORS/CONTRIBUTORS at this stage, since this feels like a very small change that doesn't warrant adding me in there. I've happy to release any copyright claim on this PR.

sbinet commented 6 years ago

I'd prefer to have proper attribution of all the work poured into this repo. "tout travail merite salaire" :) (which I'd translate to "no work is too small to be properly recognized".)

AndreRenaud commented 6 years ago

Sure, no problem.

sbinet commented 6 years ago

@AndreRenaud ping ? (just one last small effort and I can merge this in :P)

AndreRenaud commented 6 years ago

Sorry, I thought the last commit I sent through had the appropriate attribution. Is this one ok: https://github.com/go-sqlite/sqlite3/pull/26/commits/9d2936c7672a2f34ca42357776a8a0d9fe7b8a4b? I may have missed a step.

sbinet commented 6 years ago

my bad :)

(I usually ask for a separate PR that only deals with the A+C stuff. but ok)