search

go-stack / stack

Package stack implements utilities to capture, manipulate, and format call stacks.
MIT License
395 stars 33 forks source link

Test using latest point release #20

Closed kevinburke closed 6 years ago

kevinburke commented 6 years ago

Specifying "1.7" will test with 1.7, not with 1.7.6 or whatever. We probably want the latter as that's the one with bug fixes and the one people are likely to be running in production.

Also test Go 1.10.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 94.301% when pulling e5bd9ca91c2cd26f51ba3f29015e24677ab9ef75 on kevinburke:travis into eae8a16536bfb3b6f2fe8656215fede452b4b1fa on go-stack:develop.

ChrisHines commented 6 years ago

Very nice, thank you.

I'd like to ask a favor, though. Please rebase and retarget this PR for the develop branch. I like to use a Git-flow workflow on this project (see below for rationale). I apologize that I don't have contributing docs to explain that.

Rationale for Git-flow: Integrating code outside of the master branch before making releases helps keep master and the latest stable release in sync. I believe that has been the best approach with the way go get has worked prior to the introduction of modules.

kevinburke commented 6 years ago

Done