go-stack / stack

Package stack implements utilities to capture, manipulate, and format call stacks.
MIT License
397 stars 34 forks source link

Feature GitHub actions #26

Closed ChrisHines closed 3 years ago

kishaningithub commented 3 years ago

@ChrisHines Just curious.. Why close this PR instead of merging it?

ChrisHines commented 3 years ago

@kishaningithub It's been a few months, so I don't remember the specifics, but I was just learning how to use Github actions and making many mistakes. I wasn't sure if they were supposed to work on PR branches or not. I did eventually get it working, but in the process I had merged the branch offline without using the PR merge button. 🤷