search

go-stack / stack

Package stack implements utilities to capture, manipulate, and format call stacks.
MIT License
397 stars 34 forks source link

Add goang 1.16.x to the matrix build #28

Closed kishaningithub closed 3 years ago

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 92.056% when pulling 3d26fccea0e2897eb9e2144b2a44e4cb229a8c44 on kishaningithub:patch-1 into 2fee6af1a9795aafbe0253a0cfbdf668e1fb8a9a on go-stack:master.

ChrisHines commented 3 years ago

Thanks for the PR! But it will need some changes to make it right. Let me explain ....

For better or worse, I've been using the git-flow branching model on this project. I picked that approach back when this package was pretty new and Go modules didn't exist yet. It had the benefit of only merging to the master branch when I tagged a new release, which meant that the default go get behavior in those pre-modules days resulted in people only getting the latest tagged release. Obviously that is less valuable now, but the newest code in this repo is still on the develop branch which only gets merged to master when tagging a release.

So, to do this PR right it should start from the develop branch and also target the develop branch. You will find that the develop branch has a Github Actions based build instead of TravisCI. But Go 1.16.x is also missing from the Github Actions config, so it does need updating.

kishaningithub commented 3 years ago

@ChrisHines Thanks for the very detailed response! Have created the below PR on the develop branch to add go 1.16

https://github.com/go-stack/stack/pull/29

Closing this PR in favor of that one