search

go-stack / stack

Package stack implements utilities to capture, manipulate, and format call stacks.
MIT License
397 stars 34 forks source link

Add 1.16.x and 1.17.x to the build matrix #29

Closed kishaningithub closed 3 years ago

ChrisHines commented 3 years ago

@kishaningithub Do you plan to add the working directory configuration? If not, I can take over this PR if you want.

kishaningithub commented 3 years ago

@ChrisHines Thanks a lot for your patience. Have added the working-directory explicitly as you requested and also have added the brand new go 1.17 version to the build matrix :-)

ChrisHines commented 3 years ago

Awesome! Hopefully that's all we need. Kicking off the builds. We'll see how it goes.

ChrisHines commented 3 years ago

OK, only the -trimpath builds fail, which is expected. So we're good to go. Thanks for the PR!