search

go-stack / stack

Package stack implements utilities to capture, manipulate, and format call stacks.
MIT License
397 stars 34 forks source link

Dropping support for older go versions #30

Open kishaningithub opened 3 years ago

kishaningithub commented 3 years ago

I see we are supporting a lot of go versions

https://github.com/go-stack/stack/blob/e5bbd7df104bcb242ace8dd02f8f9ab6b816de08/.github/workflows/test.yml#L14

I think we can drop support for versions prior to go modules

https://github.com/go-stack/stack/pull/25#issuecomment-774845654

Keeping the above PR in mind we can keep the minimum to go 1.12

ChrisHines commented 3 years ago

I think that's fair. I have been working on some improvements along those lines in the background, time permitting. The challenge has been that as I worked on expanding the test coverage to handle some of the newer features in Go I discovered that it is tricky to get this package to produce consistent results with various combinations of GOPATH vs. modules and -trimpath or no -trimpath. One of my ideas to work around those challenges involves taking advantage of runtime/debug.BuildInfo (added in Go 1.12), to figure out which parts of the paths are the module path. But testing that has been complicated by https://github.com/golang/go/issues/33976.

kishaningithub commented 2 years ago

In my opinion we can keep the go min version as 1.15