go-task / vscode-task

Task for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=task.vscode-task
MIT License
36 stars 4 forks source link

add Settings option to always create a new Terminal instance when outputTo=terminal #126

Closed yoiang closed 5 months ago

yoiang commented 6 months ago

Hello y'all! This PR addresses the most basic part of #124 and #125 by adding a Settings option to have "outputTo": "terminal" always create a new Terminal instance. Since this requires a bit more work on the user's part to keep from creating a mess of Terminal windows this behavior defaults to false, ie: turned off.

I will attempt a second PR that will add the Settings option to create Terminal windows that end their process once the Task has finished (and prompt with the Press any key to close VSCode uses)

pd93 commented 5 months ago

@yoiang thanks for the contribution! I've made a couple of changes in 5c14e5c. The setting you've added will now be nested under some dedicated terminal settings:

{
    ...
    "task": {
        "terminal": {
            "per": "task", // default is "window"
        }
    }
    ...
}

Very open to feedback.

yoiang commented 5 months ago

Awesome! 🤩

beholdr commented 3 months ago

When this will be released in VSCode marketplace?