search

go-text / typesetting

High quality text shaping in pure Go.
Other
88 stars 11 forks source link

[fontscan] Specify Location in AddFace #119

Closed benoitkugler closed 6 months ago

benoitkugler commented 7 months ago

Let the user choose the Location when adding a Face (for #112).

benoitkugler commented 6 months ago

Merging this 'trivial' API change thanks to our updated merging policy (#125).

whereswaldon commented 6 months ago

@benoitkugler For future reference, any breaking change to the public API does need multiple reviewers, even if it is trivial. It will make downstream projects fail to compile against our main branch. If we'd implemented this by adding an alternative method, I think I'd feel differently.