search

go-text / typesetting

High quality text shaping in pure Go.
Other
101 stars 10 forks source link

ci: update to latest staticcheck #45

Closed whereswaldon closed 1 year ago

whereswaldon commented 1 year ago

Just a version bump for the linter and some adaptations to newer lint rules.

whereswaldon commented 1 year ago

Looks good. I am curious why those lint ignores are not needed now though.

I suspect that they're only enforced when your go.mod declares a sufficiently high version of go. Since we're striving to be backwards compatible pretty far, staticcheck is probably disabling them for us.

andydotxyz commented 1 year ago

Looks good. I am curious why those lint ignores are not needed now though.

I suspect that they're only enforced when your go.mod declares a sufficiently high version of go. Since we're striving to be backwards compatible pretty far, staticcheck is probably disabling them for us.

Oh I like it, that's smart :)

benoitkugler commented 1 year ago

Thanks for the cleanup !