go-vikunja / app

MIT License
251 stars 23 forks source link

Error for self-signed certificate #26

Closed thelazyoxymoron closed 1 year ago

thelazyoxymoron commented 1 year ago

Currently Vikunja expects server address to be in a particular format. It should always be https://subdomain.domain.tld/ (ending it with slash is important).

It should also accept below combinations:

When used with https://subdomain.domain.tld (without the trailing slash), it throws this error:

vikunja-error

kolaente commented 1 year ago

@Benimautner can you take a look?

Benimautner commented 1 year ago

I'd argue that removing the need to specify the protocol (http or https) is a security risk. A compromise would be a dropdown to select either http or https. I cannot reproduce the error with the trailing slash on https://try.vikunja.io . For me, all of the options below work:

Could you share some more information about your instance? Are you using a self-signed certificate?

thelazyoxymoron commented 1 year ago

Alas, it seems I had overlooked a simple nginx redirection for base /.

My setup is: docker compose with Nginx Proxy Manager (NPM) where NPM generates LetsEncrypt certificates for each of the proxy hosts. All I needed to do was to add a base / location redirection in nginx config.

Documenting it in case someone stumbles across the same issue. Refer to the below screenshot:

image