search

go-vikunja / vikunja

Mirror of vikunja from https://code.vikunja.io/api
GNU Affero General Public License v3.0
773 stars 56 forks source link

Wrong color of Card tittle when switching to Dark mode #129

Closed hugosxm closed 7 months ago

hugosxm commented 7 months ago

Description

Hi,

I just tried to color cards, and I found that when you switch theme from light to dark, it reverts color of the colored card, but this is not good, if you choose a yellow or white color you won't be able to read the tittle anymore :

Dark mode :

vikunja_dark

Light mode : vikunja_light

Dark mode should revert color of the tittle only for cards that are close to black and white I think.

Sorry if this is not clear ^^

Vikunja Frontend Version

0.21.0

Vikunja API Version

0.21.0

Browser and version

No response

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

No response

kolaente commented 7 months ago

Fixed in 34e4862c88904f114a36e65c851361b11443fadd. Please check with the next unstable build.

hugosxm commented 7 months ago

@kolaente Yep ! Much better ! Thanks for the very quick fix !!

hugosxm commented 5 months ago

@kolaente sorry but i just saw this :

vikunja_card_color

Maybe we should fix all the text of the card and not just the tittle ...

kolaente commented 5 months ago

Pushed another fix in da311fce9ebe3261b74b2f159e01d00a1284133e - please check again with the next unstable build.

hugosxm commented 5 months ago

Seems the same to me, i used sha256:300eb43e01de4cec355bd197d2d62f8a872b55a088ee178a6a53cd2a757edf67 image, pushed two hours ago ? Am I on the right image to test ?

kolaente commented 5 months ago

@hugosxm which Vikunja version is that?

hugosxm commented 5 months ago

@kolaente from the webui : Version : 0.22.0+68-c7b70844c6

kolaente commented 5 months ago

Seems to work fine for me. Can you share a screenshot and explain what you think is wrong?

hugosxm commented 5 months ago

I have exaclty the same behavior, like my screenshot 3 days ago, I tried to clean the cache, different browser... weird

EDIT : On the red card the number is colored right, but not the task progression :

vikunja_card_color2

@kolaente

kolaente commented 5 months ago

Pushed another fix for this in cd0149ef69a58e2c00e68541f3c26745fee218df. Please check again with the next unstable build (in ~45min)

hugosxm commented 5 months ago

I still see color mismatches, I tried all the predefined colors, the first one, the blue is not working by the way.

Maybe I should try with a fresh install ? Each time I tested, I tested on my existing vikunja as I tought it is safe because it is the frontend part not the api part...

vikunja_card_color

kolaente commented 5 months ago

Does it work on try?

hugosxm commented 5 months ago

@kolaente yes it works on the demo ! I forgot that vikunja have this public demo ...

But the blue color is not working on the demo too ^^ if you selected blue the card stay uncolored

EDIT : I switched my own vikunja from 0.22.0 to 0.22.1 ( as I saw the release just now ) on BOTH api and frontend and now it works ! But still no blue card ...

kolaente commented 5 months ago

@hugosxm The blue color issue should be fixed in https://github.com/go-vikunja/frontend/commit/6cc75928d8ffd0ecf6ba082425e80bfff8519bbe