Saved filter used on overview page setting overrides due date filter used on upcoming tab

jegelandsdal commented 8 months ago

Description

Setting “saved filter used on the overview page” in general settings prevents the date range filter under the upcoming tab from applying. Instead, all tasks matching the saved filter are shown, regardless of the due date and date range settings. Steps to recreate:

Create a task with a due date in the future.
Create a saved filter that will match task created.
Under Settings → General Settings add the saved filter to the “saved filter used on the overview page” option and save.
Navigate to the “Upcoming” tab and select a date range that shouldn’t include the task created. Result: The task will be shown in the upcoming tab, even though the date range does not match the due date. It seems that the tasks that match the saved filter will be shown, regardless of the date range selected.
Expected: The upcoming tab and selected date range will filter tasks according to due date and the saved filter won’t apply to the upcoming tab. Notes: I’ve tested this with a saved filter that matches a tag, as well as a saved filter that matches an assigned user, it does not seem to be specific to the saved filter criteria. I also noticed that the “saved filter used on the overview page” setting does not appear until the first saved filter is created. Once you create a saved filter, the setting appears but is blank. Once this setting is populated with the saved filter, the bug appears. Attempting to remove the saved filter from this setting does not appear to work. The only way I’ve found to remove this setting once applied is by deleting the saved filter specified or switching the saved filter specified to a throwaway saved filter and deleting that saved filter.

Vikunja Frontend Version

0.21.0

Vikunja API Version

0.21.0

Browser and version

Firefox 118.0.1

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

Task with due date and saved filter matching task Saved Filter and Task Highlighted Setting the "saved filter used on the overview page" to the saved filter Saved Filter on Overview Highlighted Upcoming tab showing task despite the due date not matching the date range selected Upcoming Highlghted

kolaente commented 7 months ago

Fixed in 7f279c98e1c855a50604bc00f208ded968339593. Please check with the next unstable build if the problem really went away.

jegelandsdal commented 7 months ago

This appears to be fixed on demo site. Thank you!

go-vikunja / vikunja