search

go-vikunja / vikunja

Mirror of vikunja from https://code.vikunja.io/api
GNU Affero General Public License v3.0
906 stars 63 forks source link

Side by Side editor feature breaks everything #161

Closed thelicato closed 1 year ago

thelicato commented 1 year ago

Description

When using the editor (i.e. writing a description, posting a comment and so on) if I click on the "Side by side" icon it becomes full screen and it is impossible to deactivate it. The only working solution is to refresh the page.

Vikunja Frontend Version

0.20.1

Vikunja API Version

0.20.1

Browser and version

Chrome Version 107.0.5304.110 (Official Build) (64-bit)

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

Screenshot from 2022-11-15 10-47-35 Screenshot from 2022-11-15 10-47-49

dpschen commented 1 year ago

You can close it via esc.

Still not, how it should be! The toolbar is hidden behind the navigation. Is this how you made the second screenshot @thelicato?

We are in the process of replacing our editor with TipTap (also see wip pull request: https://kolaente.dev/vikunja/frontend/pulls/2222). I guess this is an error big enough so that it makes sense to fix it before we go merge that.

To reveal the editor navigation, we only have to move it down, that's an easy fix.

But if you click then the Side-by-side button again it stays in fullscreen but switches to the single column (markdown) mode. If you click the button another time you go back to the described two column fullscreen.

@kolaente Do you remember the user was intended to get out of this mode (aside of esc)? Was there a close button or something?

Also I'm not sure if opening the editor in fullscreen is what one would suspect to happen when clicking on the side-by-side button.

thelicato commented 1 year ago

The second screenshot is taken after clicking on the Side by side button inside a Task modal. Yep it's a bit confusing for the user

dpschen commented 1 year ago

Ahh, that's why the main navigation doesn't overlay the editor menu.

kolaente commented 1 year ago

@kolaente Do you remember the user was intended to get out of this mode (aside of esc)? Was there a close button or something?

AFAIK there should be a button in the toolbar to get out again. I didn't implement this though, that's a feature of the editor.

The fix should be to make the toolbar visible. If that's too much work I think we can get by with just removing the button in the editor toolbar alltogether as we'll replace the editor anyway.

dpschen commented 1 year ago

I found a setting in EasyMDE (our current editor) which lets you disable the going to fullscreen in the side-by-side mode. I made a pull request, where you can check out in the preview how that would look: https://kolaente.dev/vikunja/frontend/pulls/2710

What do you think? Should we disable fullscreen?

kolaente commented 1 year ago

Fixed in https://github.com/go-vikunja/frontend/commit/98b38af43c3acc9822f167ebca295f5aecb4908d