search

go-vikunja / vikunja

Mirror of vikunja from https://code.vikunja.io/api
GNU Affero General Public License v3.0
758 stars 55 forks source link

quick add magic repeating tasks not working correctrly #271

Closed sergue2 closed 2 weeks ago

sergue2 commented 3 weeks ago

Description

There seems to be a bug in adding a repeating tasks via quick add magic. This only works for days. Unfortunately, it does not work with weeks, months years.

Vikunja Version

v0.23.0

Browser and version

Firefox, Chrome and Desktop App

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

No response

kolaente commented 3 weeks ago

Can you provide an example query which does not work?

sergue2 commented 3 weeks ago

I made a mistake. It also works for weeks, but not for months and years. You can simply use the examples from the quick add magic guide:

Every month Every 6 months Every year Every 2 years

kolaente commented 2 weeks ago

Resolved in 9f604eca79fae17cbd27d50c2ee36e37224ef1f8.

Originally, it was possible to specify repeating intervals for months or years. This was actually misleading because the interval would be converted to seconds under the hood, causing all kinds of problems with leap years and months with 30 vs 31 days. Because of that, the options for month and year were removed in 7746d3916157e43fca7a24e2a768f7fb83136cf1 to make it clear what these actually meant. Now, since we do have a repeating mode "Monthly", this commit changes the behavior to repeat a task monthly when it was specified as "every month", but only that. All other cases were removed from the docs since they are not actually supported.

sergue2 commented 2 weeks ago

this is somewhat impractical because, as you said, each month has a different number of days. Just out of interest: Why don't you use the date format for these repeating tasks instead of converting everything into seconds? Background: We have many tasks that always have to be completed on the 15th of each month, for example.

hesne commented 2 weeks ago

Resolved in 9f604ec.

Now, since we do have a repeating mode "Monthly", this commit changes the behavior to repeat a task monthly when it was specified as "every month", but only that. All other cases were removed from the docs since they are not actually supported.

Could you please clarify where I can find "monthly"? I can only see every XX hours/days/weeks

grafik

kolaente commented 2 weeks ago

this is somewhat impractical because, as you said, each month has a different number of days. Just out of interest: Why don't you use the date format for these repeating tasks instead of converting everything into seconds? Background: We have many tasks that always have to be completed on the 15th of each month, for example.

@sergue2 This is exactly what monthly repeat mode is for. Set it to repeat monthly and it will only increase the month by 1 every time you mark it done.

Could you please clarify where I can find "monthly"? I can only see every XX hours/days/weeks

@hesne Right under the dropdown "Wiederholungsmodus".